Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GetAttestationChallenge() implementation to DeviceProxy.cpp #19058

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Move GetAttestationChallenge() implementation to DeviceProxy.cpp #19058

merged 1 commit into from
Jun 1, 2022

Conversation

g-coppock
Copy link
Contributor

Followup from #18867 (comment)

@boring-cyborg boring-cyborg bot added the app label Jun 1, 2022
@g-coppock g-coppock mentioned this pull request Jun 1, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jun 1, 2022 •
edited
Loading

PR #19058: Size comparison from 393b319 to 077a24c

Increases (6 builds for cc13x2_26x2, cyw30739, p6)
platform target config section 393b319 077a24c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 162692 162700 8 0.0
pump-app LP_CC2652R7 (read only) 676539 676547 8 0.0
.text 586972 586980 8 0.0
pump-controller-app LP_CC2652R7 (read only) 654467 654475 8 0.0
.text 570176 570184 8 0.0
shell LP_CC2652R7 (read only) 641482 641490 8 0.0
.text 559728 559736 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 630938 630946 8 0.0
.app_xip_area 535988 535996 8 0.0
p6 all-clusters-minimal-app default (read/write) 2487440 2487456 16 0.0
.text 1445704 1445720 16 0.0
Decreases (6 builds for cc13x2_26x2, efr32)
platform target config section 393b319 077a24c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648467 648459 -8 -0.0
.text 563700 563692 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615299 615291 -8 -0.0
.text 541148 541140 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 680131 680123 -8 -0.0
.text 583044 583036 -8 -0.0
pump-app LP_CC2652R7 (read/write) 167452 167444 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189380 189372 -8 -0.0
efr32 window-app BRD4161A (read only) 899928 899912 -16 -0.0
.text 899920 899904 -16 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 393b319 077a24c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 648467 648459 -8 -0.0
(read/write) 158900 158900 0 0.0
.bss 74580 74580 0 0.0
.data 3404 3404 0 0.0
.rodata 84531 84531 0 0.0
.text 563700 563692 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 615299 615291 -8 -0.0
(read/write) 158072 158072 0 0.0
.bss 73812 73812 0 0.0
.data 3344 3344 0 0.0
.rodata 73915 73915 0 0.0
.text 541148 541140 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 680131 680123 -8 -0.0
(read/write) 162692 162700 8 0.0
.bss 72604 72604 0 0.0
.data 3268 3268 0 0.0
.rodata 96603 96603 0 0.0
.text 583044 583036 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 629531 629531 0 0.0
(read/write) 145724 145724 0 0.0
.bss 68340 68340 0 0.0
.data 3268 3268 0 0.0
.rodata 96483 96483 0 0.0
.text 532556 532556 0 0.0
pump-app LP_CC2652R7 (read only) 676539 676547 8 0.0
(read/write) 167452 167444 -8 -0.0
.bss 73004 73004 0 0.0
.data 3304 3304 0 0.0
.rodata 89083 89083 0 0.0
.text 586972 586980 8 0.0
pump-controller-app LP_CC2652R7 (read only) 654467 654475 8 0.0
(read/write) 189380 189372 -8 -0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83811 83811 0 0.0
.text 570176 570184 8 0.0
shell LP_CC2652R7 (read only) 641482 641490 8 0.0
(read/write) 154456 154456 0 0.0
.bss 76932 76932 0 0.0
.data 3408 3408 0 0.0
.rodata 81522 81522 0 0.0
.text 559728 559736 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 622242 622242 0 0.0
.app_xip_area 525820 525820 0 0.0
.bss 79064 79064 0 0.0
.data 708 708 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 630938 630946 8 0.0
.app_xip_area 535988 535996 8 0.0
.bss 77624 77624 0 0.0
.data 676 676 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571050 571050 0 0.0
.app_xip_area 466172 466172 0 0.0
.bss 87224 87224 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914992 914992 0 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 914984 914984 0 0.0
BRD4161A+rpc (read only) 949148 949148 0 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 949140 949140 0 0.0
BRD4161A+rs911x (read only) 789868 789868 0 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 789860 789860 0 0.0
lock-app BRD4161A+wf200 (read only) 954880 954880 0 0.0
(read/write) 128244 128244 0 0.0
.bss 126172 126172 0 0.0
.data 2068 2068 0 0.0
.text 954872 954872 0 0.0
window-app BRD4161A (read only) 899928 899912 -16 -0.0
(read/write) 133256 133256 0 0.0
.bss 131160 131160 0 0.0
.data 2092 2092 0 0.0
.text 899920 899904 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 1005652 1005652 0 0.0
(read/write) 1480042 1480042 0 0.0
.dram0.bss 69144 69144 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 210808 210808 0 0.0
.flash.text 1005652 1005652 0 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1060759 1060759 0 0.0
(read/write) 482256 482256 0 0.0
.dram0.bss 74664 74664 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 241388 241388 0 0.0
.flash.text 1055375 1055375 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 680796 680796 0 0.0
.bss 80168 80168 0 0.0
.data 2012 2012 0 0.0
.text 596912 596912 0 0.0
lock k32w061+release (read/write) 732828 732828 0 0.0
.bss 80600 80600 0 0.0
.data 1980 1980 0 0.0
.text 648544 648544 0 0.0
linux all-clusters-app debug (read only) 2770337 2770337 0 0.0
(read/write) 178272 178272 0 0.0
.bss 86240 86240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83848 83848 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 244413 244413 0 0.0
.text 2351970 2351970 0 0.0
all-clusters-minimal-app debug (read only) 2647457 2647457 0 0.0
(read/write) 170304 170304 0 0.0
.bss 85504 85504 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76728 76728 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1016 1016 0 0.0
.rodata 246333 246333 0 0.0
.text 2228562 2228562 0 0.0
bridge-app debug+rpc (read only) 2030649 2030649 0 0.0
(read/write) 147896 147896 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65496 65496 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169504 169504 0 0.0
.text 1704626 1704626 0 0.0
chip-tool debug (read only) 9682125 9682125 0 0.0
(read/write) 600688 600688 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 569296 569296 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497725 497725 0 0.0
.text 7795813 7795813 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9423052 9423052 0 0.0
(read/write) 666929 666929 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 604696 604696 0 0.0
.dynamic 528 528 0 0.0
.got 14984 14984 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461204 461204 0 0.0
.text 7437988 7437988 0 0.0
lighting-app debug+rpc (read only) 2320321 2320321 0 0.0
(read/write) 153536 153536 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 70984 70984 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188520 188520 0 0.0
.text 1966050 1966050 0 0.0
lock-app debug (read only) 2259209 2259209 0 0.0
(read/write) 148632 148632 0 0.0
.bss 73440 73440 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67912 67912 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 201608 201608 0 0.0
.text 1897282 1897282 0 0.0
ota-provider-app debug (read only) 2069089 2069089 0 0.0
(read/write) 141584 141584 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 180984 180984 0 0.0
.text 1729010 1729010 0 0.0
ota-requestor-app debug (read only) 2097121 2097121 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 176992 176992 0 0.0
.text 1759570 1759570 0 0.0
shell debug (read only) 2574425 2574425 0 0.0
(read/write) 201680 201680 0 0.0
.bss 117096 117096 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77464 77464 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 224530 224530 0 0.0
.text 2190450 2190450 0 0.0
thermostat-no-ble arm64 (read only) 2367572 2367572 0 0.0
(read/write) 177457 177457 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80216 80216 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148740 148740 0 0.0
.text 1989184 1989184 0 0.0
tv-app debug (read only) 2878417 2878417 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78224 78224 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 222880 222880 0 0.0
.text 2472930 2472930 0 0.0
tv-casting-app debug (read only) 5430665 5430665 0 0.0
(read/write) 226000 226000 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 138760 138760 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 340384 340384 0 0.0
.text 4731026 4731026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2424928 2424928 0 0.0
.bss 202620 202620 0 0.0
.data 5872 5872 0 0.0
.text 1387572 1387572 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187971 1187971 0 0.0
bss 141277 141277 0 0.0
rodata 152780 152780 0 0.0
text 815028 815028 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136703 1136703 0 0.0
bss 140506 140506 0 0.0
rodata 129344 129344 0 0.0
text 788036 788036 0 0.0
p6 all-clusters-app default (read/write) 2541504 2541504 0 0.0
.bss 137104 137104 0 0.0
.data 2808 2808 0 0.0
.text 1499768 1499768 0 0.0
all-clusters-minimal-app default (read/write) 2487440 2487456 16 0.0
.bss 136328 136328 0 0.0
.data 2744 2744 0 0.0
.text 1445704 1445720 16 0.0
light-app default (read/write) 2421392 2421392 0 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379656 1379656 0 0.0
lock-app default (read/write) 2439440 2439440 0 0.0
.bss 129248 129248 0 0.0
.data 2568 2568 0 0.0
.text 1397704 1397704 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 780200 780200 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 551572 551572 0 0.0
lighting-app tlsr9518adk80d (read/write) 800244 800244 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 568314 568314 0 0.0

@bzbarsky-apple
Copy link
Contributor

Thank you!

@bzbarsky-apple bzbarsky-apple merged commit 9111757 into project-chip:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@emargolis emargolis emargolis approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g-coppock @bzbarsky-apple @msandstedt @emargolis